summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
-rw-r--r--gd_diff.py4
-rw-r--r--tests/test_gd_diff.py8
2 files changed, 6 insertions, 6 deletions
diff --git a/gd_diff.py b/gd_diff.py
index ac79d20..a290c0d 100644
--- a/gd_diff.py
+++ b/gd_diff.py
@@ -79,14 +79,14 @@ def execute(cmd, out=None, err=None):
def read_packages(pkgs_file):
- """Return an iterator contaning of package names from `pkgs_file`.
+ """Return list contaning of package names from `pkgs_file`.
"""
pkgs = read_file(pkgs_file).split('\n')
# sanitize
pkgs_iter = map(lambda x: x.strip(), pkgs)
- return pkgs_iter
+ return list(pkgs_iter)
def get_packages(release):
diff --git a/tests/test_gd_diff.py b/tests/test_gd_diff.py
index eb3b81e..33ce492 100644
--- a/tests/test_gd_diff.py
+++ b/tests/test_gd_diff.py
@@ -86,14 +86,14 @@ class TestGdDiff(object):
def test_read_packages(self):
- pkgs_iter = read_packages(self.pkgs_file)
- assert len(list(pkgs_iter)) == 82
+ pkgs = read_packages(self.pkgs_file)
+ assert len(pkgs) == 82
def test_read_packages_sanity(self):
- pkgs_iter = read_packages(self.pkgs_file)
+ pkgs = read_packages(self.pkgs_file)
- for pkg in pkgs_iter:
+ for pkg in pkgs:
assert not ' ' in pkg